[Clam-devel] formant extractor [PATCH]es

[abe kazemzadeh]

Hi All,

Here are patches that I"ve been working on

Polynomial_new_class.patch
* root solving class Polynomial.*xx
* now using std::vector instead of CLAM::Matrix
* using float.h

LPModel_add_ToRoots.patch
* member function to LP model that calls the root solving function of the
Polynomial class

FormantExtractor_for_NetworkEditor.patch
*a network editor processing that outputs a SpectralPeakArray of formants

ProcessingTree_register_FormantExtractor.patch
*registers the FormantExtractor processing in the Network Editor.
(the attached clamnetwork files demo it).

One thing that I wanted to get feedback on for a possible future refactoring
of the root solving functionality.  Right now it's implemented as a function
call, but the more I get familiar with clam methodology, it seems like it
would be very clam-ish/clammy  to do it as a processing, where the data in
would be a polynomial and the output would be an array of roots.  However,
maybe this is overkill and it makes more sense to just keep it as a member
function.

Thanks for any feedback,
Abe

PS, when I was running scons in the test directory, I had compiling
problems, I think b/c of cppunit (the original error is
scons: Reading SConscript files ...
Package cppunit was not found in the pkg-config search path.
Perhaps you should add the directory containing `cppunit.pc'
to the PKG_CONFIG_PATH environment variable
No package 'cppunit' found
scons: done reading SConscript files.
scons: Building targets ...
g++ -DCLAM_FLOAT -DUSE_PTHREADS=1 -DUSE_XERCES=1 -DCLAM_USE_XML
-DUSE_LADSPA=1 -DUSE_FFTW=1 -DUSE_SNDFILE=1 -DUSE_OGGVORBIS=1 -DUSE_MAD=1
-DUSE_ID3=1 -DUSE_ALSA=1 -DUSE_JACK=1 -DUSE_PORTAUDIO=1 -DWITH_MAD=1
-DWITH_VORBIS=1 -O3 -fomit-frame-pointer -g -Wall
-DTEST_DATA_PATH="\"/home/abe/projects/clam/clam-test-data\""
-DCLAM_MODULE="\"tests\"" -I/usr/local/include -I/usr/local/include/CLAM
-I/usr/local/include -IFunctionalTests/include -IUnitTests/CommonHelpers
-IUnitTests -IFunctionalTests/CommonHelpers -IFunctionalTests/include
-IFunctionalTests/include -c -o
FunctionalTests/ProcessingTests/TestMultiChannelAudioFileReader.o
FunctionalTests/ProcessingTests/TestMultiChannelAudioFileReader.cxx
FunctionalTests/ProcessingTests/TestMultiChannelAudioFileReader.cxx: In
member function `void
CLAMTest::MultiChannelAudioFileReaderFunctionalTest::testConfigure_DefaultChannelSelection_PortNumberIsOK()':
FunctionalTests/ProcessingTests/TestMultiChannelAudioFileReader.cxx:161:
error: no matching function for call to `assertEquals(int, ptrdiff_t,
CppUnit::SourceLine, const char[1])'
FunctionalTests/ProcessingTests/TestMultiChannelAudioFileReader.cxx: In
member function `void
CLAMTest::MultiChannelAudioFileReaderFunctionalTest::testConfigure_ManualChannelSelection_PortNumberIsOK()':
FunctionalTests/ProcessingTests/TestMultiChannelAudioFileReader.cxx:215:
error: no matching function for call to `assertEquals(int, ptrdiff_t,
CppUnit::SourceLine, const char[1])'
scons: ***
[FunctionalTests/ProcessingTests/TestMultiChannelAudioFileReader.o] Error 1
scons: building terminated because of errors.

I couldn't find cppunit.pc on my computer (I also tried installing several
cppunit version, 1.10.2 and 1.12.0).  I also tried specifying different
cppunit-prefix's to scons...  Anyone have some idea of what might be wrong?
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.clam-project.org/pipermail/clam-devel-clam-project.org/attachments/20070725/45972290/attachment-0002.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Polynomial_new_class.patch
Type: application/octet-stream
Size: 10788 bytes
Desc: not available
URL: <http://lists.clam-project.org/pipermail/clam-devel-clam-project.org/attachments/20070725/45972290/attachment-0012.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: LPModel_add_ToRoots.patch
Type: application/octet-stream
Size: 2758 bytes
Desc: not available
URL: <http://lists.clam-project.org/pipermail/clam-devel-clam-project.org/attachments/20070725/45972290/attachment-0013.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: FormantExtractor_for_NetworkEditor.patch
Type: application/octet-stream
Size: 6004 bytes
Desc: not available
URL: <http://lists.clam-project.org/pipermail/clam-devel-clam-project.org/attachments/20070725/45972290/attachment-0014.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ProcessingTree_register_FormantExtractor.patch
Type: application/octet-stream
Size: 13924 bytes
Desc: not available
URL: <http://lists.clam-project.org/pipermail/clam-devel-clam-project.org/attachments/20070725/45972290/attachment-0015.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: tmp.clamnetwork
Type: application/octet-stream
Size: 4107 bytes
Desc: not available
URL: <http://lists.clam-project.org/pipermail/clam-devel-clam-project.org/attachments/20070725/45972290/attachment-0016.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: tmp.clamnetwork.pos
Type: application/octet-stream
Size: 416 bytes
Desc: not available
URL: <http://lists.clam-project.org/pipermail/clam-devel-clam-project.org/attachments/20070725/45972290/attachment-0017.obj>