[Clam-devel] ladspa bug fix

[Pau Arumi]

En/na Andreas Calvo ha escrit:
> In order to clean code from LADSPA, a small bug fix patch has been done 
> in the ProcessingTree.cxx file.
> The fact is that whenever creating a new QTreeWidgetObject [1], two 
> parameters must be provided. The second one is what will be the name of 
> the item, and by default is stored on column 0.
> But, as LADSPA requires to store a description and a factory identifier, 
> it was using a hidden column 1 to store the factory ID, and via #ifdef 
> selecting which column to use to instantiate the object.
> Now both CLAM plugins and LADSPA plugins use column 1, so no selection 
> has to be made.

you didn't sent the patch. but i guess it's the one same one you
sent me privately yesterday afternoon (attached).
btw, this should be considered a refactoring not a fix since its
cleaner code keeping the same behavior.

committed in revision 10017.

and let's keep doing refactorings! :)

pau

-------------- next part --------------
A non-text attachment was scrubbed...
Name: ladspa-column1-refactoring.patch
Type: text/x-diff
Size: 560 bytes
Desc: not available
URL: <http://lists.clam-project.org/pipermail/clam-devel-clam-project.org/attachments/20070418/febe72e1/attachment-0003.patch>