[Clam-devel] [PATCH] fftw3-wisdom again and SConstruct imrovements

[David García Garzón]

On Tuesday 19 June 2007 22:12:37 Roman Goj wrote:
> David García Garzón wrote:
> > Roman, your patch is commit 10267
> >
> > The fftw3 is also used in the FFT_fftw3 and IFFT_fftw3 classes. Should we
> > add the line to them too or is not good to import more than once?
>
> Wow, a great feeling, this is then my first official accepted commit to
> CLAM :')
>
> So, to celebrate - the patch for fftw3 in FFT_fftw3 and IFFT_fftw3
> (sorry, forgot about those...). Importing wisdom more then once should
> not do any harm - I think fftw just doesn't do anything if there is no
> more wisdom to be found (tried importing more then once, nothing bad
> ever happened)...
>
> ...but this reminded me that we should also be forgetting the wisdom, so
> that the memory it uses is freed, so also added this to the patch -
> fftw_forget_wisdom(). (I forgot about this, because I never used it for
> my own small projects, but it should probably be there)
>
> Thanks, David, for the commit :)
> Roman

Committed r10269. But please review what i told you on my previous mail about 
wisdom forgetting policy.

By the way, just to make it easier for us to apply them, create the patches at 
the upper level of the svn trunk. So all the patches (also the ones affecting 
applications) can be applied blindly from that same point. You made them from 
the CLAM directory.

David.