[Clam-devel] [PATCH] TonalAnalysis configuration, take two

Roman Goj roman.goj at gmail.com
Thu Jul 12 10:10:57 PDT 2007


Next configurable parameters - hopRatio and PeakWindowingEnabled
(sorry for bundling two together, hope this time it's not that much of
a problem?):

So the patch:
* Adds _peakWindowingEnabled accessor in Simac::ChordExtractor
* Adds hopRatio accessors in Simac::ChordExtractor
* _hopRatio and _peakWindowing are now configurable in TonalAnalysis
* changes a little the accessor from previous patch...

About the last part:

On 7/12/07, David García Garzón <dgarcia at iua.upf.edu> wrote:
> I do like Qt way which enables both languages.
>
> void enableThis(bool enabled=true)
> {
>         _this=enabled;
> }
> void disableThis()
> {
>         enableThis(false)
> }
>
> The second method is provided just for convenience.  Do not provide it if you
> are not using it at all.

I like this :)

So I didn't provide disableThis, if I can do something in one line of
code instead of four... chose to provide only enableThis(bool
enabled=true)

roman
-------------- next part --------------
A non-text attachment was scrubbed...
Name: TonalAnalysisConfig-step2-hopRatio-PeakWindowing.patch
Type: text/x-diff
Size: 2406 bytes
Desc: not available
URL: <http://lists.clam-project.org/pipermail/clam-devel-clam-project.org/attachments/20070712/13ff7088/attachment-0003.patch>


More information about the clam-devel mailing list