[Clam-devel] [PATCH] segmentation in chord extractor as a seperate class

[David García Garzón]

Doxygenating back
A attribute1; ///< the documentation for attribute
Doxygenating front
/// the documentation for attribute
A attribute1; 

std::endl implies std::flush

And yes, commented out code is a hell. It is better to use svn and patches as 
backups. Ill commit it so you can remove it on the next patches.

Your next step, doing the pool filling in a loop after having filled it all 
instead filling it incrementally taking the content of those new vectors. 
Which stone is safer for you? Implementing that on the destructor (you should 
make available the pool and the extractor to the destructor) or implementing 
it on the dumper (you should provide const accessors to the new vectors).

As you removed pool and extractor members, the first option may seem a back 
step, it is a safer longer way. Depending on how you perform the second 
option, it may be a dangerous jump but it is more close to the end and you 
can do it carefully. You are the one on the rope.



On Tuesday 24 July 2007 13:21:39 Roman Goj wrote:
> Hullo!
>
> So I didn't manage to accomplish much yesterday... but finally the
> patch flow continues :)
>
> This one takes care of:
>
> On 7/19/07, David García Garzón <dgarcia at iua.upf.edu> wrote:
> (...)
>
> > Goal 1 remove reference to the pool (after each step compile test and
> > patch)
>
> (...)
>
> > * Create a vector of time positions and another of chord indexes as
> > members * Populate them as the chordSegmentation and pool. (do not remove
> > the old code)
>
> (...)
>
> So changelog:
> * ChordExtractorSegmentation now has members for holding time
> positions of the segments and the chord indexes
> * They are filled in ChordExtractorSegmentation::doIt() in the same
> loop that now writes to the pool
>
> There is some useless commented out code that I used for getting sure
> I understand everything correctly, this will get removed soon, but I'd
> like to keep it there for the next few patches - just in case...
>
> More to come :)
> roman