[Clam-devel] Re: [PATCH] time seeking, work in progress

Roman Goj roman.goj at gmail.com
Tue Aug 14 14:17:22 PDT 2007


Roman Goj wrote:
> Hullo!
> 
> After getting time output from the AudioFileReaders, I've been working
> on implementing seeking within a file... but this turned out to be much,
> much harder... lots of digging through code, false leeds, and generally
> fun :-)
(...)
> What doesn't work:
> (don't get me started on what *doesn't* work ;-) )
> * ...obviously mpeg and pcm don't work (pcm should be easy though,
> mpeg... I'm not sure)

Good news is:
pcm more or less works (limited testing, but it seems to be working
nicely here :) )

Bad news is:
now I am sure getting mpeg to work will be hard :-( (at least for me it
will be...)

So...
it's more then 3 hours now since I said on #clam that I'm giving myself
2 more hours to work on this and then I stop and focus on my GSoC tasks
(because "real life" can seek in time veeeeeery quickly, and soon it
will be mEOFReached == false; and then GSoC_ASSERT( mEOFReached, "Game
Over" ) ...ekhm... ;-) ).

So - I have to leave the code as it is. I'd say it should be quite
useful (at least for work on wave or ogg files) ... and also - if anyone
needs to implement mp3 (or timeseeking multichannelaudiofilereader) - a
guide to doing it (just look at the .patch file and compare the ogg/pcm
files to mpeg files).

I guess the code isn't really committable without changes, so - if you'd
like to use it (globot? does this actually help you?), just apply the
patch and off you go :) (patch -p0 < timeseeking.patch)

Also attached is a small .clamnetwork file I use for testing :)
(monoaudiofilereader will need reconfiguring though - just pick a
wav/ogg file from your drive - I used a mono version of a GSoC podcast
...to keep me motivated to finish soon and get back to my main tasks ;-) )

Of course - come September - if noone finishes this patch - I'd like to
get back to it :-) (not nice to be leaving things in an unfinished state...)

cheers,
roman
-------------- next part --------------
A non-text attachment was scrubbed...
Name: timeseeking-alsoinpcm.patch
Type: text/x-diff
Size: 7375 bytes
Desc: not available
URL: <http://lists.clam-project.org/pipermail/clam-devel-clam-project.org/attachments/20070814/d662834c/attachment-0003.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: monoaudio.clamnetwork
Type: text/xml
Size: 1170 bytes
Desc: not available
URL: <http://lists.clam-project.org/pipermail/clam-devel-clam-project.org/attachments/20070814/d662834c/attachment-0003.bin>


More information about the clam-devel mailing list