[Clam-devel] [PATCH] IMPORTANT change: making Processing::GetConfigure not mandatory

Xavier Amatriain xavier at create.ucsb.edu
Tue May 15 11:11:21 PDT 2007


On Mon, 2007-05-14 at 18:41 +0200, Pau Arumi wrote:
> Implement virtual ProcessingConfig& GetConfigure() const at the
> base class, returning a static NullProcessingConfig.

Completely in favor. Let's go for it!!

> Change behaviour of Processing::Processing() so it leaves the
> processing in Configured state.

I would probably argue theoretically about whether this is correct or
not. However, I agree that in practice this has shown to be default
behavior and this change would make user's life much easier. So I agree
this is good.

> So without the constructor and GetConfig methods a simple
> processing looks like this:
> 
> class MyProcessing : public CLAM::Processing
> {
> 	CLAM::InPort<float> mIn;
> 	CLAM::OutPort<float> mOut;
> public:
> 	const char* GetClassName() const { return "MyProcessing"; 	}
>   	~MyProcessing() {}

Shouldn't we make this destructor explicitly "virtual"?


-- 
/*********************************
 *       Xavier Amatriain        *
 *  Associate Director - MATi    *
 *  Research Director - CREATE   *
 *    UCSB, Santa Barbara CA     *
 *      1-(805)- 893 83 52       *
 ********************************/





More information about the clam-devel mailing list