[Clam-devel] [PATCH] fftw3-wisdom again and SConstruct imrovements

[David García Garzón]

Nice patch, Roman. On the commit cue for today.

Anyway I was thinking, that the wisdom is a single one for the whole program, 
isn't it? So if you create two FFT's, and destroy one (an easy thing to do in 
the NetworkEditor) maybe you are forgeting the wisdom of both of them, and 
loading the wisdom twice!!

I'll commit it anyway. But, could you investigate how does it really works? 
Has the library a counter, does it load once or again for every time we do?

We had a similar problem with Xerces (xml) initialization. We solved using 
static objects. But the solution depends on what fftw3 does. So investigate 
what it does and then lets discuss a solution.

I would like to discuss with you the roadmap on the irc.

After having this solved. I think you should move your energies towards fully 
understanding the TonalAnalysis algorithm: how the postprocessing works on 
the streaming and offline versions (streaming version has no segmentation at 
all) and how to clean and improve it. Still the offline segmentation is very 
naive.

Yesterday i added some documentation to tonal analysis classes on the 
development version of doxygen:
http://clam.iua.upf.edu/doc/CLAM-devel-doxygen/namespaceSimac.html

Also all 'processing' classes on the Simac namespace are not CLAM processings. 
This is another TO-DO. but i would delay it until the postprocessing code 
make-up.

Cheers.


On Tuesday 19 June 2007 22:12:37 Roman Goj wrote:
> David García Garzón wrote:
> > Roman, your patch is commit 10267
> >
> > The fftw3 is also used in the FFT_fftw3 and IFFT_fftw3 classes. Should we
> > add the line to them too or is not good to import more than once?
>
> Wow, a great feeling, this is then my first official accepted commit to
> CLAM :')
>
> So, to celebrate - the patch for fftw3 in FFT_fftw3 and IFFT_fftw3
> (sorry, forgot about those...). Importing wisdom more then once should
> not do any harm - I think fftw just doesn't do anything if there is no
> more wisdom to be found (tried importing more then once, nothing bad
> ever happened)...
>
> ...but this reminded me that we should also be forgetting the wisdom, so
> that the memory it uses is freed, so also added this to the patch -
> fftw_forget_wisdom(). (I forgot about this, because I never used it for
> my own small projects, but it should probably be there)
>
> Thanks, David, for the commit :)
> Roman