[Clam-devel] [PATCH] Update NetworkEditor getLabel()

David García Garzón dgarcia at iua.upf.edu
Tue Jul 17 11:54:00 PDT 2007


No objections at all. Commit it. Then read this.

Small patch proposal: Notice that most of those functions created an static 
dummy string and returned it. This was needed since the return value was a 
reference, but now that's not needed, so the code can be simplified to a
	return 'dummyValue';

After that small patch we need bigger changes to get the impression of real 
progress. Some ways we can take:

* Synchronizing views zoom and position
* Make the rulers share canvas with Plots (now they are separate widgets)
* Turn the Spectrogram into a texture
* Add the spectrogram as a different kind of plugin/view on the Annotator
* Abstract Spectrogram as an Array of Arrays DataSource so it can be applied 
to other 2D data such as MFCC, Chromagram, PCP's...
* Fixing the SegmentEditor interaction
* Completing the SegmentEditor modes (Continuous, Overlapping, Unsized...)
* The so-called-plugins in Annotator should use Factory as we do with 
Processings
* Any other you feel comfortable to do it first.

Not needed to be in this order... so consider them all and pick one that you 
can achieve shortly. Then propose a modification route.


On Tuesday 17 July 2007 19:11:11 bennett kolasinski wrote:
> Attached is a patch that updates NetworkEditor's
> FloatArrayDataSource::getLabel(unsigned bin) to return a copy of a string
> rather than a reference to a string-- this is to keep the function in sync
> with Annotator's version.  If there aren't any objections, I'll commit
> later this afternoon (US time).
> B






More information about the clam-devel mailing list