[Clam-devel] SMSSynthesys and phase management.

[Pau Arumi]

applied, all tests keep in green, and commited.
so now you can sync again with svn.

thanks for the patch!

pau



En/na Giulio Paci ha escrit:
> Pau Arumi ha scritto:
>> (please remember to keep the threads on-list)
>>
>> En/na Giulio Paci ha escrit:
>>> Pau Arumi ha scritto:
>>>> En/na Giulio Paci ha escrit:
>>>>> in SMSSynthesis.cxx overwrites our phase values.
>>>>> We saw that we can set an attribute "Type" (in the
>>>>> PhaseManagementConfig
>>>>> attribute of our SMSSynthesisConfig instance, mSynthConfig) that
>>>>> can be
>>>>> set to "Align", "Continuation" or "Random".
>>>>> But we need something that would do nothing. Currently we have
>>>>> commented
>>>>> out mPhaseMan.Do(inputSinusoidalPeaks); but we think this is a very
>>>>> bad solution. Is it possible to add something like "None" as a Type
>>>>> option?
>>>> my first thought is: yes, a None type would make sense for
>>>> what you do.
>>> Ok, then I'm going to write a patch as soon as I can.
>> good!
>>
>> p.
> Here is the "eNone" patch. :-)
> 
> Giulio.
> 
> 
> 
> 
> ------------------------------------------------------------------------
> 
> Index: src/Processing/Synthesis/EPhaseGeneration.hxx
> ===================================================================
> --- src/Processing/Synthesis/EPhaseGeneration.hxx	(revisione 9830)
> +++ src/Processing/Synthesis/EPhaseGeneration.hxx	(copia locale)
> @@ -40,7 +40,8 @@
>  	typedef enum {
>  		eAlign,
>  		eRandom,
> -		eContinuation
> +		eContinuation,
> +		eNone
>  	} tEnum;
>  
>  	virtual Component* Species() const
> @@ -53,6 +54,7 @@
>  			{eAlign,"Align"},
>  			{eRandom,"Random"},
>  			{eContinuation,"Continuation"},
> +			{eNone,"None"},
>  			{0,NULL}
>  		};
>  		return sEnumValues;
> Index: src/Processing/Synthesis/PhaseManagement.cxx
> ===================================================================
> --- src/Processing/Synthesis/PhaseManagement.cxx	(revisione 9830)
> +++ src/Processing/Synthesis/PhaseManagement.cxx	(copia locale)
> @@ -98,6 +98,10 @@
>  			DoRandomPhases(in);
>  			break;
>  		}
> +		case (EPhaseGeneration::eNone):
> +		{
> +			break;
> +		}
>  	}
>  	return true;
>  }