[Clam-devel] CombFilter and GenderChange

[Xavier Amatriain]

The comb filter effect is not to remove background noises but to remove 
any possible remainders of the
original pitch in the residual. Those are much more noticeable when you 
shift the sinusoidal component.

So, if there are noises in the residual... well, that's a different issue.

But, didn't this break like half of our functional tests? Why wasn't the 
patch discussed in the list before
committing it? (just trying to make my point for the *other* discussion ;).

David García Garzón wrote:
> Yes sorry. The Combfilter i disabled was the one on the PitchShift, and yes, 
> it was suffering this bug. I added an 'if (false ...' on line 93 to disable 
> it. The result is better than the result of enabling it but i listen a 
> background alias sound that i think it was intended to be removed by the comb 
> filter, wasn't it?
>
>
> On Divendres 13 Abril 2007, Xavier Amatriain wrote:
>   
>> I assume you are talking about the CombFilter in the PitchShift... is
>> the PitchShift affected by that bug? Is it still working
>> correctly?
>>
>> David García Garzón wrote:
>>     
>>> Xavi, on the list, but this mail is addressed to you.
>>>
>>> When i did the GenderChange fixes for realtime i had to disable the
>>> CombFilter it contains. It generated a lot of sharp noise on the residual
>>> branch. The transformation still generates some weird noises which maybe
>>> were removed by that filter. I don't know.
>>>
>>> No hurry but TODO: could you take a look at the CombFilter, fix and
>>> reenable it and also check the overall transformation to check whether it
>>> is sounding as it was intended to sound?
>>>
>>>
>>> ------------------------------------------------------------------------
>>>
>>> _______________________________________________
>>> Clam-devel mailing list
>>> Clam-devel at llistes.projectes.lafarga.org
>>> https://llistes.projectes.lafarga.org/cgi-bin/mailman/listinfo/clam-devel
>>>       
>> _______________________________________________
>> Clam-devel mailing list
>> Clam-devel at llistes.projectes.lafarga.org
>> https://llistes.projectes.lafarga.org/cgi-bin/mailman/listinfo/clam-devel
>>     
>
>
>
>