[Clam-devel] [PATCH] IMPORTANT change: making Processing::GetConfigure not mandatory

[Pau Arumi]

En/na David García Garzón ha escrit:
> 1- I would add a 'typedef NullProcessingConfig Config' on the base Processing. 
> Derived processing classes could still redefine such inner type to use other 
> ProcessingConfig other than the null one.

commited

> 2- Currently processings are unconfigured until you call Configure with the 
> proper configuration object type (normally the constructor calls it with a 
> default configuration object). On the implementation Pau sent, by default 
> processing objects are configured without even having called Configure. I 
> think this is not convenient. I think ConcreteProcessing implementers should 
> call Configure(Config()) on the constructor or the processing should be 
> unconfigured.

Done David's way since still there is no agreement on making 
processings configured by default. So lots go for the 
conservative option by the moment.



commit 10114

  * Changes in Processing base class
  ** Implement virtual ProcessingConfig& GetConfigure() const at the
     base class, returning a static NullProcessingConfig. Before 
it was
     virtual pure.
  ** Added Processing::Config typedef defined as NullProcessingConfig
     so processing writers can use Configure( Config() ); in 
their ctr.
  ** Added GetExecStateString() method for debugging