[Clam-devel] Re: KeySpace and Tonnetz dummy data sources

[bennett kolasinski]

David (& list):

I just got back from my trip (no internet for 3 days- the horror!!) and
while I was working in my sandbox I noticed that the implementations of
TonnetzPlugin and KeyspacePlugin within InstantViewPlugin.cxx were virtually
the same except for the string id of each class... so I set to work on
reworking those two classes into default implementations for all the virtual
functions instead of two classes with 99% the same code... I figured this
would make adding a plugin (such as BarGraph) as simple as inheriting from
InstantViewPlugin and simply passing the id string to the constructor
(unless you needed to override any of the functions).

Anyhow, I made a big mess and overwrote my backed-up copies of
InstantViewPlugin.[c/h]xx so I'm updating my source now.  This was after
spending some time working on integrating BarGraph so all is not lost but
I'd like to spend a bit of time cleaning up what I've done before sending
anything out.

So I guess the purpose of this email is twofold: 1) seeing if anyone wanted
to argue against changing InstantViewPlugin into default implementations for
its virtual functions instead of having to implement each function for each
plugin class and 2) to say that I'll be working more on rolling BarGraph
into Annotator and will have something to send out shortly :)

----------
Bennett

On 6/4/07, David García Garzón <dgarcia at iua.upf.edu> wrote:
>
> Bennett, if you already did any change to Tonnetz don't update your
> sandbox or
> you might get some conflicts. I did some changes to get ride of the Dummy
> data sources for KeySpace and Tonnetz. If you send the patch to the list
> ill
> try to merge it.
>
> The changes i did consisted on removing the DummyXXXDataSources  classes
> on
> the KeySpace and Tonnetz which provided dummy constant data for qt
> designer.
> I used instead the generic dummy data source i already used for the
> BarGraph,
> the DummyFloatArrayDataSource class which is 'programable' with the
> constant
> data to show. I just added programmable labels to fit KeySpace and Tonnetz
> needs.
>
> When you split the monitor class all the common files will get 'almost'
> identical.
>
> Looking forward your changes, it will be very interesting viewing PCP's
> and
> MFCC's as a BarGraph on the Annotator.
>
> --
> David García Garzón
> (Work) dgarcia at iua dot upf anotherdot es
> http://www.iua.upf.edu/~dgarcia
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.clam-project.org/pipermail/clam-devel-clam-project.org/attachments/20070606/2cf0b88e/attachment-0004.htm>