[Clam-devel] [PATCH] setting incontrol bounds (spectralNetwork.clamnetwork)

[Pau Arumi]

En/na Pau Arumi ha escrit:
> En/na Hernán Ordiales ha escrit:
>> hi all,
>>
>> This patch covers SpectralDelay, ThreeBandFilter and Robotization
>> processings (from example-data/spectralNetwork.clamnetwork)
>>
>> parumi, i have a couple of questions:
>>
>> * if now default values are set in "ConcreteConfigure(...)", have
>> sense to redefine a void "InitControls(...)"?
> 
> Yes you're right. InitControls is not abstract so no need to define. 
> I've modified your patch removing them.
> 
>> * i didn't knew which names to choose to replace the mAmount value, i
>> chose a temporary "mMain". Let me know
>>
>> * i think mAmount isn't used in ThreeBandFilter class, i replaced it
>> anyway for the learn process, but i think is useless and if i'm not
>> wrong isn't used in the Do() algorithm. I'm losing something?
> 
> These two concerns are the same, I think. Yes, ThreeBandFilter does not 
> use mAmount. No problem about that, the only hassle is that in 
> NetworkEditor we'll still see the first incontrol "Amount". But we'll 
> get rid of them all in next steps.
> 
> There's no need to add this mMain in-control (you added it only in 
> ThreeBandFilter). It is not substituting anything and it is neither used.

... So I've removed it from the patch.
The patch also includes the spectralTransformation.clamnetwork
without the "Main" control connection.


> Committed at revision 10228
>