[Clam-devel] [PATCH] fftw3-wisdom again and SConstruct imrovements

[David García Garzón]

Roman, your patch is commit 10267

The fftw3 is also used in the FFT_fftw3 and IFFT_fftw3 classes. Should we add 
the line to them too or is not good to import more than once?

David.


On Saturday 16 June 2007 12:22:06 Roman Goj wrote:
> Hi!
>
> It's me again with another two extremely simple patches...
>
> The fftw3-wisdom patch adds only one line of code... the fourier
> transform with this patch tries to import the system wisdom. The
> subsequent plan calculation still uses FFTW_ESTIMATE, so that if there
> is no system wisdom available fftw3 won't try to search for the plan
> thoroughly. Fortunately it turns out that if the system wisdom is
> found, it's used even if FFTW_ESTIMATE is used :)
>
> ... Of course the real problem is how to best approach precalculating
> the wisdom... so apart from that single line I put some 50 more into
> the INSTALL file (also mentioning release=1, put a new chapter there -
> 4. Tips for increasing performance) I suppose even if you decide it
> should not be in the INSTALL file, we could put that somewhere...
>
> Also I made small changes to the SConstruct file... now I know why I
> didn't find the release=1 option by myself... It's suppsed to be
> visible in what scons --help produces... but I've been running scons
> --help and I never waited for the help to be printed, because I saw
> the install directory info and the sign BUILDING CLAM LIBRARIES and
> never thought it was actually going to display the help and not start
> building again (I know, I know, stupid, inpatient me... :) If you're
> reading this Hernan - then this explains why I didn't see the distcc
> help info :) )
>
> So I put an
> if not '--help' in sys.argv and not '-h' in sys.argv
> before the print commands and now they aren't displayed when only help
> is required...
>
> Also I'm quite sure this:
> '--help' in COMMAND_LINE_TARGETS
> in line 280 does nothing (at least on my system) - '--help' is not in
> COMMAND_LINE_TARGETS even if I run scons --help ...
> at least it's not displayed when I run
> print COMMAND_LINE_TARGETS
> and it didn't work in the if's... only sys.argv worked...
>
> OK, Sorry I just keep sending such annoyingly small patches... ;)
>
> Cheers!
> roman