[Clam-devel] [PATCH] (work in progress) Harmonizer

[Pau Arumi]

En/na Hernán Ordiales ha escrit:
> On 7/10/07, Pau Arumi <parumi at iua.upf.edu> wrote:
>> En/na Hernán Ordiales ha escrit:
>> > On 7/9/07, Pau Arumi <parumi at iua.upf.edu> wrote:
>> >> 2) Control api is something very "core" and so it needs to be
>> >> covered by unit tests. So please, try adding simple tests that
>> >> checks the behaviour of SetDefault() in
>> >> CLAM/test/UnitTests/ControlsTests/ControlsTest.cxx
>> >> Actually unit tests not only assess that code is working, but also
>> >> is a means for doing api specification.
>> >
>> > ok, added
>>
>> Commited it as is (in rev 10371). However I'd like more changes
>> --it's a matter of details. Tell me if you prefer me to take it.
> 
> ok, told me These kind of changes are useful for me to learn more
> about CLAM  (or are comments below?)

yes they are the previous comments :)

...
> but isn't, they are correct, they are initialized with 0. and 1., then
> default it's 0.5 if bounds were not set... its ok for me (that should
> be a unit test?)

no (i'm telling by memory). because we already cover that 1)
default bounds are 0,1 and 2) default value is bounds mean.
butom line: unit tests should cover everything but only once.

> another question, i was trying to add the configuration object to
> harmonizer processing... but i'm getting this assert:
> 
> At file scons/libs/core/include/CLAM/Processing.hxx line 396
> Configuring a Processing with a configuration not being the proper type.

it is typically when you are passing an object which is not of the
same type as mConfig. if it's not the case, send a patch to
reproduce it.

pau