[Clam-devel] Re: test changes after refactoring of InstantTunningEstimator

[Roman Goj]

On 7/11/07, Roman Goj <roman.goj at gmail.com> wrote:
> On 7/10/07, David García Garzón <dgarcia at iua.upf.edu> wrote:
> > Next,
> > * Locate and solve any remaining InstantTunningEstimator constructed with
> > bpo!=1
> > * Compile, Test, Patch
> > * Turn the bpo default value to 1
> > * Compile, Test, Patch
> > * Use the default bpo instead of explicitly put 1
> > * Compile, Test, Patch
>
> Did these points for now.

(Patch includes the previous one)

Missed two occurences of the constructor of InstantTunningEstimator
used with _binsPerSemitone - corrected.

So this patch takes care of:
NEW:
* _binsPerSemitone is no longer an argument for the constructor, it's
just inside InstantTunningEstimator
OLD (but corrected) :
* InstantTunningEstimator's constructor now has a default of 1
* InstantTunningEstimator now constructed without the use of the
second parameter (in the tests and ChordExtractor.hxx, did I miss
anything?)
* removes useless doIt in InstantTunningEstimator
* use make_pair() instead of std::pair's constructor

more patches to follow, stay tuned :-)
roman
-------------- next part --------------
A non-text attachment was scrubbed...
Name: InstantTunningEstimatorTest-step5-interface-change.patch
Type: text/x-diff
Size: 4357 bytes
Desc: not available
URL: <http://lists.clam-project.org/pipermail/clam-devel-clam-project.org/attachments/20070711/5bf88e5f/attachment-0005.patch>