[Clam-devel] Re: test changes after refactoring of InstantTunningEstimator

[Roman Goj]

(This patch includes step4 and step5 and step6)

This patch adds a helper function for the last two tests... but I'm
not really sure this is the way this should be done, so - waiting for
comments :)

So the final list of changes included in this patch:
NEW:
* a helper function replaces most of the code in the last two tests in
InstantTunningEstimatorTest
OLD:
* _binsPerSemitone exchanged for '1' in InstantTunningEstimator
* InstantTunningEstimator's constructor now has a default of 1
* InstantTunningEstimator now constructed without the use of the
second parameter (in the tests and ChordExtractor.hxx, did I miss
anything?)
* removes useless doIt in InstantTunningEstimator
* use make_pair() instead of std::pair's constructor

Eagerly awaiting the verdict on these patches :-)

(To everyone on the list not interested in these, who managed to come
this far in the thread: Sorry for the flood!)

cheers!
roman
-------------- next part --------------
A non-text attachment was scrubbed...
Name: InstantTunningEstimatorTest-step7-helper-function-for-two-last-tests.patch
Type: text/x-diff
Size: 7524 bytes
Desc: not available
URL: <http://lists.clam-project.org/pipermail/clam-devel-clam-project.org/attachments/20070711/d7bd5609/attachment-0005.patch>