[Clam-devel] Re: Patch for Steps of LoadFrom

David García Garzón dgarcia at iua.upf.edu
Mon Jun 16 11:11:07 PDT 2008


El Monday 16 June 2008 18:56:49 David García Garzón va escriure:
> What a nice patch! Commited. You got one in for the commit wings :-)
>
> BTW, you removed the const modifier for some test data. That is a hint that
> we should have defined takeArray (and constructor) parameters as 'const
> TData *'
>
> If you have time before the meeting do it. If not, i would prefer you to go
> on on other tasks, so i'll do it myself.

I had to as the patch broke testfarm. Annotator was feeding const data as it 
is natural to do, and it didn't compile.

It broke testfarm so it was half a nice patch ;-) Anyway keep that good pace. 
You are on the track.

David.





More information about the clam-devel mailing list