[Clam-devel] Re: Segmentation component to Pool

[JunJun]

hi,
the patch for the last session, and the comments are as below:

* Jun patch. Hopefully the end for this session
** fix the bug of ContiguousSeg by moving maxPos to the last offset;
** add LoadFrom xml, with/without MaxPos, and no-within/within an array, pass the tests respectively.

The next target is to make an python script that changes the old segmentation syntax to the new one. Super!

Bests,
Jun

----- Original Message ----- 
From: "David García Garzón" <dgarcia at iua.upf.edu>
To: "JunJun" <wangjun at dsp.ac.cn>
Cc: <clam-devel at llistes.projectes.lafarga.org>
Sent: Wednesday, June 18, 2008 5:53 PM
Subject: Re: Segmentation component to Pool


> On Wednesday 18 June 2008 03:23:21 JunJun wrote:
>> > On Dimarts 17 Juny 2008, JunJun wrote:
>> > > Below is the statuses of each step in this patch.
>> > > storing array tests:  status- GREEN
>> > > loading maxpos:  status- GREEN
>> > > loading without maxpos:  status- GREEN
>> > > loading arrays: status- RED
>> > >
>> > > I've no idea whether the implementation of an array
>> > > "XmlStorage::Restore(segmentations, stream);" is right or not, any
>> > > idea?
>> > >
>> > > Bests,
>> > > June
>> >
>> > If the segmentations in the xml are not equal why do you expect equal
>> > segmentations on the assert sentences?
>>
>>  To make sure that it will be RED.
> 
> 
> Ah, ok, that's perfect, a RED is a required step but it should last for 
> short. ;-) But if the current implementation is also RED no need to fake the 
> test. Anyway i think that the implementation should work.
> 
> The problem is not on the implementation but again in the test. Add an assert 
> on the array size and you will get a hint on what's happening.
> 
> David.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: MaxPos2XML5.patch
Type: application/octet-stream
Size: 13112 bytes
Desc: not available
URL: <http://lists.clam-project.org/pipermail/clam-devel-clam-project.org/attachments/20080623/e1cd5f9c/attachment-0003.obj>