[Clam-devel] ProcessingTree patch: if the processing box have an icon, show it on the tree

Natanael Olaiz nolaiz at gmail.com
Tue May 6 01:00:25 PDT 2008


El 05/06/2008 04:22 AM, David García Garzón escribió:
> Cool! Just a suggestion to improve the patch: reduce duplication.
>
> Call GetValueFromAttribute once and store it in a var. If it is empty then 
> assign it to "processing.png". Then call setIcon once.
>
>   

Like this? (If I don't get first all the values I get a segmentation 
fault...)
Is not simpler to read in the other way?


Best regards,
Natanael.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: Alternate_iconInProcessingTree.patch
Type: text/x-patch
Size: 817 bytes
Desc: not available
URL: <http://lists.clam-project.org/pipermail/clam-devel-clam-project.org/attachments/20080506/c8381c0b/attachment-0004.bin>


More information about the clam-devel mailing list