[Clam-devel] Patch: embedded diagrams widgets for faust plugins

Pau Arumí Albó parumi at iua.upf.edu
Wed Jun 25 03:17:12 PDT 2008


El dl 23 de 06 de 2008 a les 23:16 -0300, en/na Natanael Olaiz va
escriure:
> >> Who will use that method?
> 
>  > RunTimeFaustLibraryLoader::SetupLibrary:
> 
>  >     std::string pluginName = 
> pluginFullFilename.substr(pluginFullFilename.rfind("/")+1,pluginFullFilename.length());
>  >     pluginName = pluginName.substr(0,pluginName.rfind("."));    // 
> crop name without extension
>  >
>  >     std::string name = 
> RunTimeLibraryLoader::ExistsDirInPaths("examples/"+pluginName+".dsp-svg");
> 
> - >    if (name == "")
> + >   if (name ! = "")
> 
>  >         factory.AddAttribute(oss.str(), "svg_diagram", name);
> 

I've looked at the semantics of ExistsDirInPath, and they still doesn't
perfectly match, to me.
The problem is that ExistsSomethig should return a bool

What we do in this method is to complete a given subdir, searching the
proper prefix path in the plugins path lists.

A suggestion: (note that we don't want/need to specify
RunTimeLibraryLoader:: )

std::string svgDiagramDir = CompletePathFor("examples/"+pluginNames
+".dsp-svg")

Check all this in, if not done already (I'll use it for the next
screenshots in my thesis :-) )

P





More information about the clam-devel mailing list