[Clam-devel] Re: TODOs

[Greg Kellum]

Hi Yushen,

> e.g. The following hierarchy of classes are re-organized by me based
> on Greg's code. All of them are plugin headers instead of system
> files.
>
> SDIFDatabase.cxx
> ->
> SDIFFileReaderWithBuffer.cxx
> ->
> SDIFFileReaderWithLoop.cxx
>
> Do you think I should keep his structure or this design when I merge
> our plugins?
> I would like to hear Greg's comments too.

I think it's probably better like you've done it.  It was a headache  
having those as system files, because that meant that anytime you made  
any changes to them you had to recompile and reinstall CLAM and then  
recompile the plugin.  And this adds 3 - 5 minutes to the build time.

If you're plugin was going to be separate from mine, they would be  
better as system files, since two plugins would be using them.  But if  
there is only going to be one SMS plugin, then you might as well keep  
them in the plugin.

Best,
Greg