[Clam-devel] Re: Patch for Steps of LoadFrom

[JunJun]

> I like this final step. Great! Just to comments:

> &ptr[size] is equivalent to the more readable ptr+size

> I would prefer if the load test does not relay in StoreOn to do the assert. I 
> would prefer you to assert on the boundsAsString method because:
> 1- it is a lot more cheaper in cpu
> 2- if the storage fails, current assert will make both the load and the store 
> tests will fail instead of just failing the store test

Thanks for all those comments. I'll resend a patch fixing those issues.
How about the meeting for the next session?


> On Dilluns 16 Juny 2008, JunJun wrote:
> > Patch of LoadFromStepEnd:
> > delete the LoadFrom method in derived classes and implement it in
> > Segmentation, and pass unittests.
> >
> > By now, the maxPosition is just set on the constructor. Here we
> > would need to change the XML format to add such a bound as part of the XML.
> > Could you schedule a meeting please?

----- Original Message ----- 
From: "David García Garzón" <dgarcia at iua.upf.edu>
To: "JunJun" <wangjun at dsp.ac.cn>
Cc: <clam-devel at llistes.projectes.lafarga.org>
Sent: Monday, June 16, 2008 5:29 PM
Subject: Re: Patch for Steps of LoadFrom