[Clam-devel] AudioFileMemoryLoader patch

[Pawel Bartkiewicz]

On 21/06/2008, David García Garzón <dgarcia at iua.upf.edu> wrote:
> in all platforms? Belive us, the delta is needed. There is arithmetic
> involved, when comparing you are substracting and comparing to 0. And it is
> safer if you use .9/samplerate delta instead 1./samplerate. Just in case.

Ok, you're right, I haven't thought about that.

> Also include <cmath> instead <math.h> and std::fabs instead fabs. If there
> is
> no need for the include to be in the hxx move it to the cxx.

Sorry, I did that by mistake and didn't notice.

> I dont think that latest revisions solve that. The step value is the step
> for
> the slider, not for the spinbox. A related todo is making the control sender
> have an step smaller than .01. Anyway when we address the feedback control
> part, we could provide a better option.

Yes, it still doesn't work as expected in the newest revision.

> Just svn add it and provide it as part of the next patch.

Well... as you wish. I'm not sure how the binary .pos file will be
handled, though.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: AudioFileMemoryLoader-position_incontrol-fixed.patch
Type: text/x-diff
Size: 3811 bytes
Desc: not available
URL: <http://lists.clam-project.org/pipermail/clam-devel-clam-project.org/attachments/20080623/220cfc48/attachment-0005.patch>