[Clam-devel] Re: faust status

[Natanael Olaiz]

Commit 11598:

     * ProcessingBox: recomputeMinimumSizes() if exists, uses
    _embedded->sizeHint as minimum size (or 500x500 as a limit, if bigger)


Commit 11599:

     * MainWindow:
            - added submenu for Faust, active if USE_LADSPA. Added a
    bool option to embed SVG diagrams
            - removed debug macros.
            - semantical changes on Faust related methods and slots
            - called _canvas->setEmbedSVGDiagramsOption when bool option
    is changed
     * (Clam)NetworkCanvas: added private: _embedSVGDiagramsOption,
    public: setEmbedDiagramsOption(bool) and bool getEmbedDiagramsOption()
     * ProcessingBoxEmbededWidgets: check for _embedSVGDiagramsOption to
    retrieve (or not) the svg_diagrams

I forgot to comment that MainWindow also save the state of 
ClamNetworkCanvas::_embedSVGDiagramsOption (which is equal to 
action_Embed_SVG_Diagrams_Option->isChecked())


El 07/11/2008 07:05 AM, Pau Arumí escribió:
> Since this faust-related work is quite isolated I think it's preferred
> that you commit directly without sending patches. I mean, treating
> commits as you treat patches now: explaining what it does, the maturity
> status, asking for feedback, etc.  This way is easier to catch up with
> you and test --I'll wait your commits to test the latest stuff.
>
> BTW, I think having faust svg enabled by default makes more sense.
>
> P
>
>
> On dv, 2008-07-11 at 04:15 -0300, Natanael Olaiz wrote:
>   
>> The same, but now the two Faust related menu actions are created from 
>> MainWindow.hxx, and appears only "ifdef USE_LADSPA".
>>
>> BTW, I just realize that the embedded svg option is not exclusive to 
>> Faust plugins. Anyway, by default it starts without it, so if you like 
>> it, I'll commit it.
>>
>> And a question. What is the best place for the slot 
>> onOptionEmbedSvgDiagramsChanged()? MainWindow, as in the patch (where 
>> the signal come), or directly on ClamNetworkCanvas (in _canvas)?
>>
>>
>> El 07/11/2008 01:48 AM, Natanael Olaiz escribió:
>>     
>>> El 07/09/2008 06:00 PM, Pau Arumí Albó escribió:
>>>       
>>>> El dc 09 de 07 de 2008 a les 22:16 +0200, en/na David García Garzón va
>>>> escriure:
>>>>  
>>>>         
>>>>>> - Hey, your screenshots have Sinks and Sources with svg diagrams. But
>>>>>> mines no. I want them! :-)
>>>>>>       
>>>>>>             
>>>>> I don't like them too much but maybe another icon could look better.
>>>>>
>>>>> I think the faust svg feature although cool and awesome, is not 
>>>>> convenient for usability because they add too much elements on the 
>>>>> screen, which is something we want to solve with the subnetworks 
>>>>> feature. Making the diagram appear on user query, maybe in a side 
>>>>> view could be better. We can now use QWebKit to have linked svg's!
>>>>>     
>>>>>           
>>>> I tend to find those diagrams useful to understand the network --which
>>>> tells me this decision might depend on the user's taste.
>>>> I'd like to avoid doing too much work now (like having a side view), and
>>>> first gain experience using faust and specially have feedback of faust
>>>> users.
>>>> Anyway, I agree that we that faust-svg diagrams could be somehow
>>>> optional: a NE bool setting "show faust svg diagrams" could
>>>> enable/disable the svg embedding *when inserting a new processing*,
>>>> which I think it's straightforward to do. David, Natanael: do you buy
>>>> it?
>>>>   
>>>>         
>>> In this patch I added the bool option to ClamNetworkCanvas, and is 
>>> managed from the menu of main window. Not the best option, because it 
>>> will be showed on non-linux environments, but I don't know where to 
>>> ask the user for the option inserting the .svg...
>>>
>>> Plus I renamed some action names on MainWindow (r11583), with 
>>> unmatched ui signals.
>>>
>>>
>>>       
>>>> P 
>>>>
>>>>   
>>>>         
>
>
>