[Clam-devel] Removing BlockingNetworkPlayer?

[Natanael Olaiz]

This was the idea?
Some code is just commented.
HasSyncSource is not used anymore but the NetworkTest. Should we kept it?


Commit 11755:

     * BlockingNetworkPlayer: removed. Not used anymore.
     * NetworkPlayer: removed IsCallbackBased() attribute
    (BlockingNetworkPlayer was the only non callback based player)
     * .*Player: commented IsCallBackBased() implementations.
     * MainWindow & PrototypeLoader:
        - commented the alsa backend support, which used
    BlockingNetworkPlayer.
        - removed the error message when is not callback based and not
    Network::HasSyncSource().
        - TODO: remove HasSyncSource attribute also?

Regards,
Natanael.


El 07/31/2008 05:35 PM, Pau Arumí escribió:
> Natanael, 
> take this task if you feel like. It's very straightforwards but will
> give you the occasion to intimate (more) with the
> NetworkPlayer-Network-FlowControl code. 
> The NetworkPlayer::IsCallbackBased() should also be removed and adapt
> the code that uses it.
>
> P
>
>
> On dj, 2008-07-31 at 21:42 +0200, David García Garzón wrote:
>   
>> El Thursday 31 July 2008 09:19:30 Pau Arumí va escriure:
>>     
>>> I am for removing the BlockingNetworkPlayer and all the accompanying
>>> code.
>>> The reason is that our backends now are limited to Jack and PortAudio
>>> which are callback-based. Other interesting backends: PulseAudio and
>>> Mac's CoreAudio, are also callback-based. The push backends if I recall
>>> correctly where ActiveX and Alsa which have been abandoned.
>>> Besides, callback-based is more efficient that push-based, we won't want
>>> to go back...
>>>
>>>       
>> It seems that is not that used at all so go ahead with it. A related removal 
>> that implies much more code reduction is AudioIO but this could have more 
>> dependencies on examples and applications that would be harder to adapt but 
>> as you feel like adventurous... ;-)
>>
>> David
>>
>>     
>
>
> _______________________________________________
> Clam-devel mailing list
> Clam-devel at llistes.projectes.lafarga.org
> https://llistes.projectes.lafarga.org/cgi-bin/mailman/listinfo/clam-devel
>
>   

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.clam-project.org/pipermail/clam-devel-clam-project.org/attachments/20080801/2a6b8fae/attachment-0004.htm>