[clam-devel] Patch: unsigned int and bracket usage

[David GARCÍA GARZÓN]

Partially commited the patch from Murray. r15180. Thanks, Murray.

I just took the approach that for every file all in or all out so i can rebuild the remaining patch without problems.

The attached patch contains the remaining changes. As i have some spare i would try to handle them by hand if Murray do not send a correct patch for them before.

Beside what i said in my former mail, i also rejected some unsigned -> int changes.
Normally unsigned should prevail, so i will take it a closer look.

David.


-----Mensaje Original-----
De Pau Arumi <pau.arumi at immsound.com>
Enviado Dom 21/08/2011 11:27
Para CLAM development list <clam-devel at lists.clam-project.org>
Asunto Re: [clam-devel] Patch: unsigned int and bracket usage

El ds 20 de 08 de 2011 a les 06:46 +0200, en/na David Garcia Garzon va
escriure:
> Some processings had the factory registration commented out, which you
> activated again. They were disabled by reasons i ignore (and are not
> documented :-P ) but i remember that for most of them there was a
> reason for that, like in TimeStretch. Pau, Xavi, could you put some
> light here? The commented processings Murray uncommented are:
> ThreeBandGate, SpectralNotch and Deesser but there are more. While we
> don't know why, i would not commit that or I would prepare a separate
> patch.

mmm i don't really remember if there was a valid reason to disable those
processing's registration - it was so long ago!. 
i'd try to enable them and see if network editor's *.clamnetwork
examples are happy.

P

_______________________________________________
clam-devel mailing list
clam-devel at lists.clam-project.org
http://lists.clam-project.org/listinfo.cgi/clam-devel-clam-project.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: removing_misc_compiler_errors-rejected.patch
Type: text/x-patch
Size: 11446 bytes
Desc: not available
URL: <http://lists.clam-project.org/pipermail/clam-devel-clam-project.org/attachments/20110907/d6494eae/attachment-0005.bin>