On Wed, May 14, 2008 at 11:45 AM, Pau Arumí <<a href="mailto:parumi@iua.upf.edu">parumi@iua.upf.edu</a>> wrote:<br><div class="gmail_quote"><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Hola Francisco!<br>
could you send me a bounce to investigate the cause?</blockquote><div>It was an smtp configuration problem:<br><div class="Ih2E3d">[...]<br>
Delivery to the following recipient failed permanently:<br>
<br>
<a href="mailto:clam-devel@llistes.projectes.lafarga.org">clam-devel@llistes.projectes.lafarga.org</a><br>
<br>
Technical details of permanent failure:<br>
PERM_FAILURE: Gmail tried to deliver your message, but it was rejected
by the recipient domain. The error that the other server returned was:
550 550 relay not permitted. We recommend contacting the other email
provider for further information about the cause of this error. Thanks
for your continued support. (state 14)<br>
</div>[...]<br> </div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><br>
<br>
About the patch. I think it's good.<br>
Just two minor comments:<br>
We have the "imperative" methods (AddLink, RemoveLink) at the out<br>
control only --which i think it's reasonable-- then why not to simplify<br>
and have IsConnectedTo only to the out control as well? Sounds like<br>
duplicated interface to me.<br>
Agree?<br>
<br>
I guess (have not looked at it) the reason behind this decision is<br>
because it is how is done in current controls. If it is the case i<br>
wouldn't mind break the symetry. Or even refactor the current controls.</blockquote><div><br>That's the reason, i just followed the current control tests and do it.<br>You are talking about IsConnectedTo only right?<br>
Because if we remove isConnected or the mLinks member from the TypedInControl we can't unlink it from the TypedOutControls when it's being destroyed.<br> template<class TypedControlData><br> TypedInControl<TypedControlData>::~TypedInControl()<br>
{<br> while (!mLinks.empty())<br> mLinks.front()->RemoveLink(*this);<br> }<br><br>If you're talking just about the IsConnectedTo, i think it's ok.<br><br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<br>
<br>
I prefer to wait to the next patch before commiting. Hopefully sending<br>
to the list works again.<br>
<br>
Also, the multiple relation (1 out -> many ins) is not tested.<br>
You could do a test like this:<br>
out --> in1<br>
\-> in2<br>
then do out.SendControl(1) and check it has been received in both<br>
inputs.</blockquote><div>I'll do this test today.<br>Also yesterday i was thinking about the inverse case (many outs -> 1 in).<br>Should i do both tests? Or you think doing many outs -> 1 in is not correct? <br>
<br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
<br>
<br>
I think next tests should introduce the generic interface. For that, the<br>
trick is using base class references to concrete objects like this:<br>
<br>
TypedInControl<int> concreteIn;<br>
TypedOutControl<float> concreteOut:<br>
BaseTypedInControl & in = concreteIn;<br>
BaseTypedOutControl & out = concreteOut;<br>
ASSERT false, in.IsLinkable(out)</blockquote><div> Ok, when you commit the patch i'll send today, i'd start with this, I think is a big patch and should be isolated from the above modifications.<br>Cambio y fuera.<br>
Francisco<br><br></div><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"><br>
<br>
<br>
Saludos!<br>
Pau<br>
<br>
<br>
<br>
<br>
<br>
<br>
El dt 13 de 05 del 2008 a les 12:52 -0300, en/na Francisco Tufró va<br>
escriure:<br>
<div><div></div><div class="Wj3C7c">> forgot the attach<br>
><br>
> On Tue, May 13, 2008 at 12:45 PM, Francisco Tufró <<a href="mailto:nictuku@gmail.com">nictuku@gmail.com</a>><br>
> wrote:<br>
> Hi guys, I'm having problems sending messages to the list (and<br>
> i haven't recieved any mail from it since sunday, and every<br>
> mail i send bounces with a relay problem while i'm not doing<br>
> relay), so i send the patch to you.<br>
> I've done the "IsConnected, IsConnectedTo" tests and the<br>
> Destructor tests (and all the implementation to pass them).<br>
> So, please tell me what should i do next.<br>
> :)<br>
> Francisco<br>
><br>
<br>
</div></div></blockquote></div><br>