I've found that some XControl direct access still exist in plugins.<br>Should i rename all these to FloatXControl?<br><br>examples/MIDIIOExample.cxx: InControl stopReceiver("stop-receiver");<br>plugins/continuousExcitationSynthesizer/SDIFDatabaseProcessing.hxx: InControl mPitchControl;<br>
plugins/continuousExcitationSynthesizer/SDIFDatabaseProcessing.hxx: InControl mAmplitudeControl;<br>plugins/continuousExcitationSynthesizer/SDIFDatabaseProcessing.hxx: InControl mBrightnessControl;<br>plugins/spacialization/src/BFormatRotation.hxx: CLAM::InControl _roll;<br>
plugins/spacialization/src/BFormatRotation.hxx: CLAM::InControl _azimuth;<br>plugins/spacialization/src/BFormatRotation.hxx: CLAM::InControl _elevation;<br>plugins/spacialization/src/IncoherenceCompensator.hxx: InControl mDeviation;<br>
plugins/spacialization/src/ComplexSpectrumMixer.hxx: InControl _gain1;<br>plugins/spacialization/src/ComplexSpectrumMixer.hxx: InControl _gain2;<br>plugins/spacialization/src/RoomImpulseResponseSimulatorCommandLine.hxx: InControl _sourceX;<br>
plugins/spacialization/src/RoomImpulseResponseSimulatorCommandLine.hxx: InControl _sourceY;<br>plugins/spacialization/src/RoomImpulseResponseSimulatorCommandLine.hxx: InControl _sourceZ;<br>plugins/spacialization/src/RoomImpulseResponseSimulatorCommandLine.hxx: InControl _listenerX;<br>
plugins/spacialization/src/RoomImpulseResponseSimulatorCommandLine.hxx: InControl _listenerY;<br>plugins/spacialization/src/RoomImpulseResponseSimulatorCommandLine.hxx: InControl _listenerZ;<br>plugins/spacialization/src/RoomImpulseResponseSimulatorCommandLine.hxx: static unsigned map(InControl & control, unsigned limit)<br>
plugins/spacialization/src/VectorBasedArrayPanning.hxx: CLAM::InControl _beta;<br>plugins/spacialization/src/BFormatRotationZoom.hxx: CLAM::InControl _roll;<br>plugins/spacialization/src/BFormatRotationZoom.hxx: CLAM::InControl _azimuth;<br>
plugins/spacialization/src/BFormatRotationZoom.hxx: CLAM::InControl _elevation;<br>plugins/spacialization/src/BFormatRotationZoom.hxx: CLAM::InControl _dominance;<br>plugins/spacialization/src/ImpulseResponseInterpolator.hxx: InControl _position;<br>
plugins/spacialization/src/Vbap3D_OneSpeaker.hxx: CLAM::InControl _azimuth;<br>plugins/spacialization/src/Vbap3D_OneSpeaker.hxx: CLAM::InControl _elevation;<br>plugins/spacialization/src/Vbap3D.hxx: CLAM::InControl _azimuth;<br>
plugins/spacialization/src/Vbap3D.hxx: CLAM::InControl _elevation;<br>plugins/spacialization/src/ImpulseResponseDatabaseFetcher.hxx: InControl _emitterX;<br>plugins/spacialization/src/ImpulseResponseDatabaseFetcher.hxx: InControl _emitterY;<br>
plugins/spacialization/src/ImpulseResponseDatabaseFetcher.hxx: InControl _receiverX;<br>plugins/spacialization/src/ImpulseResponseDatabaseFetcher.hxx: InControl _receiverY;<br>plugins/spacialization/src/ImpulseResponseDatabaseFetcher.hxx: static unsigned map(InControl & control, unsigned limit)<br>
plugins/GuitarEffects/AutomaticGainControl/AutomaticGainControl.hxx: InControl mOutputReference;<br>plugins/osc/LibloSink.hxx: InControl _in1;<br>plugins/osc/LibloSink.hxx: InControl _in2;<br>plugins/osc/LibloSink.hxx: InControl _in3;<br>
<br><div class="gmail_quote">On Wed, Feb 4, 2009 at 4:29 PM, David García Garzón <span dir="ltr"><<a href="mailto:dgarcia@iua.upf.edu">dgarcia@iua.upf.edu</a>></span> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
Just for the record, and just in case some one wants to take them before i can<br>
do it:<br>
<br>
Current refactoring status (X=In or Out):<br>
<br>
- BaseXControl: Is the base class for any X controls<br>
- XControl: Is the old control interface for just floats<br>
- TypedXControl<T>: Is the new templated interface<br>
- FloatXControl: Is a typedef to XControl to easy the transition<br>
<br>
To get there:<br>
- Most common behaviour has been moved to BaseXControl.<br>
- All uses of XControl has been renamed to BaseXControl or FloatXControl<br>
depending on the kind of usage (general or float).<br>
- Some direct control sending has been abstracted into functions living in<br>
Processing.hxx<br>
<br>
Target status:<br>
<br>
- BaseXControl: Is the base class for any X controls<br>
- XControl<T>: Is the new templated interface (renamed!)<br>
- FloatXControl: Should point to XControl<float> or we could remove it<br>
<br>
So, pending steps are:<br>
<br>
1- Converge existing differences in float interface (bounds, defaults and<br>
bool/int conversion) in BaseXControl/XTypedControl versus XControl one.<br>
2- Point FloatXControl typedef to XControl<T> and check that all is still<br>
working properly ¬¬<br>
3- Remove the XControl classes, checking that there still is no direct<br>
dependency on them<br>
4- Rename TypedXControl<T> to XControl<T> so we have the same interface than<br>
with ports.<br>
5- Rename FloatXControl usage to XControl<float> (or keep it as we have<br>
AudioInPorts as InPort<float> alias)<br>
<br>
Other issues to address eventually:<br>
<br>
6- Decide what to do with the Bound and Default interface in BaseXControl<br>
7- What to do with the free functions in Processing.hxx that handle float<br>
control sending.<br>
8- Make XControlPublishers not just float<br>
<br>
<br>
David.<br>
<br>
<br>
<br>
_______________________________________________<br>
Clam-devel mailing list<br>
<a href="mailto:Clam-devel@llistes.projectes.lafarga.org">Clam-devel@llistes.projectes.lafarga.org</a><br>
<a href="https://llistes.projectes.lafarga.org/cgi-bin/mailman/listinfo/clam-devel" target="_blank">https://llistes.projectes.lafarga.org/cgi-bin/mailman/listinfo/clam-devel</a><br>
</blockquote></div><br>