I've done the necessary changes to migrate FloatXControl from XControl to TypedXControl<float>.<br>Except for testInControlPublisher and testInControlPublisher_ConnectControlsFromPublisher all tests where ok and i compiled NetworkEditor & Annotator an run them.<br>
I send the patch through the list for you to test it better before commiting it.<br><br>
<br><div class="gmail_quote">On Fri, Feb 6, 2009 at 12:20 PM, David García Garzón <span dir="ltr"><<a href="mailto:dgarcia@iua.upf.edu" target="_blank">dgarcia@iua.upf.edu</a>></span> wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">
I guess so. Nice because compiler will warn us if there is any one left as<br>
soon as we remove the class (before renaming the template).<br>
<div><div></div><div><br>
On Friday 06 February 2009 13:42:31 Francisco Tufró wrote:<br>
> I've found that some XControl direct access still exist in plugins.<br>
> Should i rename all these to FloatXControl?<br>
><br>
> examples/MIDIIOExample.cxx: InControl stopReceiver("stop-receiver");<br>
> plugins/continuousExcitationSynthesizer/SDIFDatabaseProcessing.hxx:<br>
> InControl mPitchControl;<br>
> plugins/continuousExcitationSynthesizer/SDIFDatabaseProcessing.hxx:<br>
> InControl mAmplitudeControl;<br>
> plugins/continuousExcitationSynthesizer/SDIFDatabaseProcessing.hxx:<br>
> InControl mBrightnessControl;<br>
> plugins/spacialization/src/BFormatRotation.hxx: CLAM::InControl _roll;<br>
> plugins/spacialization/src/BFormatRotation.hxx: CLAM::InControl<br>
> _azimuth; plugins/spacialization/src/BFormatRotation.hxx:<br>
> CLAM::InControl _elevation;<br>
> plugins/spacialization/src/IncoherenceCompensator.hxx: InControl<br>
> mDeviation;<br>
> plugins/spacialization/src/ComplexSpectrumMixer.hxx: InControl _gain1;<br>
> plugins/spacialization/src/ComplexSpectrumMixer.hxx: InControl _gain2;<br>
> plugins/spacialization/src/RoomImpulseResponseSimulatorCommandLine.hxx:<br>
> InControl _sourceX;<br>
> plugins/spacialization/src/RoomImpulseResponseSimulatorCommandLine.hxx:<br>
> InControl _sourceY;<br>
> plugins/spacialization/src/RoomImpulseResponseSimulatorCommandLine.hxx:<br>
> InControl _sourceZ;<br>
> plugins/spacialization/src/RoomImpulseResponseSimulatorCommandLine.hxx:<br>
> InControl _listenerX;<br>
> plugins/spacialization/src/RoomImpulseResponseSimulatorCommandLine.hxx:<br>
> InControl _listenerY;<br>
> plugins/spacialization/src/RoomImpulseResponseSimulatorCommandLine.hxx:<br>
> InControl _listenerZ;<br>
> plugins/spacialization/src/RoomImpulseResponseSimulatorCommandLine.hxx:<br>
> static unsigned map(InControl & control, unsigned limit)<br>
> plugins/spacialization/src/VectorBasedArrayPanning.hxx: CLAM::InControl<br>
> _beta;<br>
> plugins/spacialization/src/BFormatRotationZoom.hxx: CLAM::InControl<br>
> _roll;<br>
> plugins/spacialization/src/BFormatRotationZoom.hxx: CLAM::InControl<br>
> _azimuth;<br>
> plugins/spacialization/src/BFormatRotationZoom.hxx: CLAM::InControl<br>
> _elevation;<br>
> plugins/spacialization/src/BFormatRotationZoom.hxx: CLAM::InControl<br>
> _dominance;<br>
> plugins/spacialization/src/ImpulseResponseInterpolator.hxx: InControl<br>
> _position;<br>
> plugins/spacialization/src/Vbap3D_OneSpeaker.hxx: CLAM::InControl<br>
> _azimuth;<br>
> plugins/spacialization/src/Vbap3D_OneSpeaker.hxx: CLAM::InControl<br>
> _elevation;<br>
> plugins/spacialization/src/Vbap3D.hxx: CLAM::InControl _azimuth;<br>
> plugins/spacialization/src/Vbap3D.hxx: CLAM::InControl _elevation;<br>
> plugins/spacialization/src/ImpulseResponseDatabaseFetcher.hxx: InControl<br>
> _emitterX;<br>
> plugins/spacialization/src/ImpulseResponseDatabaseFetcher.hxx: InControl<br>
> _emitterY;<br>
> plugins/spacialization/src/ImpulseResponseDatabaseFetcher.hxx: InControl<br>
> _receiverX;<br>
> plugins/spacialization/src/ImpulseResponseDatabaseFetcher.hxx: InControl<br>
> _receiverY;<br>
> plugins/spacialization/src/ImpulseResponseDatabaseFetcher.hxx: static<br>
> unsigned map(InControl & control, unsigned limit)<br>
> plugins/GuitarEffects/AutomaticGainControl/AutomaticGainControl.hxx:<br>
> InControl mOutputReference;<br>
> plugins/osc/LibloSink.hxx: InControl _in1;<br>
> plugins/osc/LibloSink.hxx: InControl _in2;<br>
> plugins/osc/LibloSink.hxx: InControl _in3;<br>
><br>
> On Wed, Feb 4, 2009 at 4:29 PM, David García Garzón<br>
<<a href="mailto:dgarcia@iua.upf.edu" target="_blank">dgarcia@iua.upf.edu</a>>wrote:<br>
> > Just for the record, and just in case some one wants to take them before<br>
> > i can<br>
> > do it:<br>
> ><br>
> > Current refactoring status (X=In or Out):<br>
> ><br>
> > - BaseXControl: Is the base class for any X controls<br>
> > - XControl: Is the old control interface for just floats<br>
> > - TypedXControl<T>: Is the new templated interface<br>
> > - FloatXControl: Is a typedef to XControl to easy the transition<br>
> ><br>
> > To get there:<br>
> > - Most common behaviour has been moved to BaseXControl.<br>
> > - All uses of XControl has been renamed to BaseXControl or FloatXControl<br>
> > depending on the kind of usage (general or float).<br>
> > - Some direct control sending has been abstracted into functions living<br>
> > in Processing.hxx<br>
> ><br>
> > Target status:<br>
> ><br>
> > - BaseXControl: Is the base class for any X controls<br>
> > - XControl<T>: Is the new templated interface (renamed!)<br>
> > - FloatXControl: Should point to XControl<float> or we could remove it<br>
> ><br>
> > So, pending steps are:<br>
> ><br>
> > 1- Converge existing differences in float interface (bounds, defaults and<br>
> > bool/int conversion) in BaseXControl/XTypedControl versus XControl one.<br>
> > 2- Point FloatXControl typedef to XControl<T> and check that all is still<br>
> > working properly ¬¬<br>
> > 3- Remove the XControl classes, checking that there still is no direct<br>
> > dependency on them<br>
> > 4- Rename TypedXControl<T> to XControl<T> so we have the same interface<br>
> > than<br>
> > with ports.<br>
> > 5- Rename FloatXControl usage to XControl<float> (or keep it as we have<br>
> > AudioInPorts as InPort<float> alias)<br>
> ><br>
> > Other issues to address eventually:<br>
> ><br>
> > 6- Decide what to do with the Bound and Default interface in BaseXControl<br>
> > 7- What to do with the free functions in Processing.hxx that handle float<br>
> > control sending.<br>
> > 8- Make XControlPublishers not just float<br>
> ><br>
> ><br>
> > David.<br>
> ><br>
> ><br>
> ><br>
> > _______________________________________________<br>
> > Clam-devel mailing list<br>
> > <a href="mailto:Clam-devel@llistes.projectes.lafarga.org" target="_blank">Clam-devel@llistes.projectes.lafarga.org</a><br>
> > <a href="https://llistes.projectes.lafarga.org/cgi-bin/mailman/listinfo/clam-devel" target="_blank">https://llistes.projectes.lafarga.org/cgi-bin/mailman/listinfo/clam-devel</a><br>
<br>
<br>
</div></div></blockquote></div><br>