<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 TRANSITIONAL//EN">
<HTML>
<HEAD>
<META HTTP-EQUIV="Content-Type" CONTENT="text/html; CHARSET=UTF-8">
<META NAME="GENERATOR" CONTENT="GtkHTML/3.26.0">
</HEAD>
<BODY>
Hi All,<BR>
<BR>
I know there is a coding guideline and discussing style is very dangerous :), but if I may, I would like to share some thoughts on what I read; the following line is from the OfflineNetworkPlayer.cxx file.<BR>
<BR>
<BR>
<TT>for(std::vector<SndfileHandle*>::iterator it=infiles.begin();it!=infiles.end();it++) delete *it;</TT><BR>
<BR>
<BR>
- please dont type everything as if it was one big word, use proper spacing like when writing text: source is meant to be read by humans (computers dont read)<BR>
<BR>
- please type ++i instead of i++: <A HREF="http://www.parashift.com/c++-faq-lite/operator-overloading.html#faq-13.15">http://www.parashift.com/c++-faq-lite/operator-overloading.html#faq-13.15</A><BR>
<BR>
- please dont put multiple statements on 1 line (return or delete after if for instance): debuggers cant set breakpoints<BR>
<BR>
<BR>
- use typedefs, its shorter, more clear as it expresses what you're doing and localizes the 'type', when you change it, you only need to change one place<BR>
<BR>
<TT> for(SndFileHandles::iterator it = infiles.begin(); it != infiles.end(); ++it) </TT><BR>
{<BR>
<TT> delete *it;</TT><BR>
}<BR>
<BR>
- please note: with the use of smartpointers, this whole line becomes obsolete as they and their resources are destructed when the vector is<BR>
<BR>
- please do not indent in namespaces: c++ is not java or c#<BR>
<BR>
<BR>
What is the lists opinion?<BR>
<BR>
Dirk<BR>
<BR>
</BODY>
</HTML>