<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On Jun 30, 2010, at 11:18 PM, Natanael Olaiz wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite">
<div bgcolor="#ffffff" text="#000000">
Hi,<br>
<br>
El 06/30/2010 09:13 PM, Xavier Serra escribió:
<blockquote cite="mid:1A54F788-A95A-41BD-8D8E-5EFB60498596@gmail.com" type="cite">
<pre wrap="">On Jun 30, 2010, at 5:01 PM, David García Garzón wrote:
</pre>
<blockquote type="cite">
<pre wrap="">On Monday 21 June 2010 17:14:57 Xavier Serra wrote:
</pre>
<blockquote type="cite">
<pre wrap="">Hi guys,
I'm Xavi Serra, an student at UPF doing his final project for CLAM with
David.
We intend to extend the funcionality of the NetworkEditor. The first
thing we are doing is to detect when a network file is outdated and
automatically throw clamRefactor (asking permission to the user to do
so).
[snip]
Xavier Serra
</pre>
</blockquote>
<pre wrap="">Committed after some refactorings we did yesterday together. Now a dialog is
shown on version mismatch and in the case of a network of an older version it
gives you the option to upgrade the network by using clamrefactor before
loading it. The upgrade is still dummy, but Xavi is already working on it.
Xavi, some screenshots would be helpful so that other developers can do
comments on usability aspects. Could you put them on the wiki?
</pre>
</blockquote>
<pre wrap=""><!---->Done.
It would be great too if you guys could give some feedback about usability issues. I think the messages are now, after David's modification, more clear but I'd prefer more opinions.
</pre>
</blockquote>
The messages are clear to me.<br>
<br>
But I have some questions:<br>
<br>
1- The clamVersion attribute did always existed on the clam network
files? (I cannot found it in the CHANGES log) If not, there are
probably no clam networks so much outdated being used... but what would
happens if it doesn't exist? From
<a class="moz-txt-link-freetext" href="http://doc.trolltech.com/4.5/qxmlquery.html#evaluateTo-4">http://doc.trolltech.com/4.5/qxmlquery.html#evaluateTo-4</a> : "If output
is null behavior is undefined." <br>
<br></div></blockquote><div><br></div><div>It didn't. Files without the attribute are treated as older file and thus, need conversion. David told me these files are pre-1.2 or so.</div><br><blockquote type="cite"><div bgcolor="#ffffff" text="#000000">
2- What would be the behavior in case of different versions? I think
that checking the version number is OK as a first test of possible
conflict between releases, but the needed changes and the definitely
tests should be done looking in a migrationScript file or something
like that. How we would deal with the different migrationScripts that
we have in the core and different plugins? We would include all of them
in the NetworkEditor to make such a test?<br>
<br></div></blockquote><div><br></div><div>When NetworkEditor detects that a file is older it will throw clamRefactor. The idea is to have a migrationScript file with the steps needed to go from version to version and use that when calling clamRefactor</div><br><blockquote type="cite"><div bgcolor="#ffffff" text="#000000">
3- David: do you think that it would be difficult to put the interface
to check the network version on the CLAM::XMLStorage class? I know that
this improvement and interface to solve the version conflict is
inherent to the NetworkEditor, but CLAM::XMLStorage would not be the
ideal place to just check the version? Maybe returning diferent error
codes on the Restore...<br>
<br>
<br>
<br>
If we maintain updated the migrationScript(s) file(s), this would be a
very nice tool. :)<br>
<br>
<br>
Best regards,<br>
Natanael.<br>
<br>
<blockquote cite="mid:1A54F788-A95A-41BD-8D8E-5EFB60498596@gmail.com" type="cite">
<pre wrap="">Xavi Serra
_______________________________________________
clam-devel mailing list
<a class="moz-txt-link-abbreviated" href="mailto:clam-devel@lists.clam-project.org">clam-devel@lists.clam-project.org</a>
<a class="moz-txt-link-freetext" href="http://lists.clam-project.org/listinfo.cgi/clam-devel-clam-project.org">http://lists.clam-project.org/listinfo.cgi/clam-devel-clam-project.org</a>
</pre>
</blockquote>
<br>
</div>
_______________________________________________<br>clam-devel mailing list<br><a href="mailto:clam-devel@lists.clam-project.org">clam-devel@lists.clam-project.org</a><br>http://lists.clam-project.org/listinfo.cgi/clam-devel-clam-project.org<br></blockquote></div><br></body></html>