[Clam-devel] [PATCH] TonalAnalysis configuration, take two

[David García Garzón]

Don't apologize for 'small' patches. That's just what it should be.

Just did some even smaller corrections to the patch before commiting:
* The delete on destructor was also guarded by if(_implementation)
* We do not use NULL, but 0 as Stroupstrup advices in his book.
* I moved the initialization to the colon initializers

This may create conflicts on your sandbox, Roman. Use revert.

On Monday 16 July 2007 16:47:08 Roman Goj wrote:
> This may seem like a tiny unimportant patch... but really it's the
> "one huge leap for a man (and thanks David!), but a small step for
> CLAM"-type-of-patch. Ok, should be the other way around, I know...
>
> I've been having trouble with new/delete _implementation in
> configuring TonalAnalysis... turns out all it took was initializing
> with a null pointer, ah, the small pleasures in life :)
>
> Also my svn diff seems to indicate there's still a fftw_forget_wisdom
> left in FFT_fftw3.cxx, so I left it in the patch...
>
> Changelog:
> * _implementation initialized with at first with a NULL pointer and
> then properly initialized in ConcreteConfigure
> * one fftw_forget_wisdom left
>
> cheers (and thanks again, David!)
> roman