[Clam-devel] [PATCH] Towards removing the old frame descriptors pane in annotator

[bennett kolasinski]

Hi David,
I *think* I'm pretty close to being able to remove the old frame descriptors
pane in annotator to replace it with the new one we've been writing, but I
wanted to send this as a patch rather than commit to make sure I'm doing the
right thing.  Please have a look.  Here are my questions / comments:

- I removed the functions from Annotator that I had moved to
FrameDescriptorsPane.  For now, I've commented out the methods that I
removed from Annotator.cxx in Annotator.hxx just to keep track of what I
removed.  The new pane seems to be functioning fine except when it comes to
dragging the playhead to a new position- it just doesn't do that.  I'm
pretty sure that's a signal that I just need to find.  Or... it may have to
do with the markCurrentSongChanged attribute / signal, which I guess I'd
have to emit from within FrameDescriptorsPane to get Annotator to update?
 (see line 168 of FrameDescriptorsPane after applying my patch)
- I presume the top widget needs to be removed through QtDesigner (or by
manually editing the .ui XML file)... but I wanted to check with you before
I went ahead with that.
- As far as synchronizing zoom, I believe it's as simple as adding another
signal connection... similar to the one that (AFAI can tell) is in
vmqt/plot/vmSegmentationPlot.cxx:166.
- As for live scrolling... I'm still looking for that but any hints are
appreciated :)

onward with the coding...  thanks!

b
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.clam-project.org/pipermail/clam-devel-clam-project.org/attachments/20070817/38f58e7e/attachment-0003.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: RemoveOldFrameDescriptorsPane.patch
Type: application/octet-stream
Size: 11961 bytes
Desc: not available
URL: <http://lists.clam-project.org/pipermail/clam-devel-clam-project.org/attachments/20070817/38f58e7e/attachment-0003.obj>