[Clam-devel] Re: [PATCH] Towards removing the old frame descriptors pane in annotator

[bennett kolasinski]

Meet the new Annotator... same as the old Annotator...
OK, in response to one of my questions... just to see what happened, I went
in and manually edited Annotator.ui and, lo and behold... it looks like it
works!  (I've posted a very uneventful screenshot showing Annotator looking
exactly like it did before David & I did our gutting of it!)

David-- again, please have a look @ the patch and let me know if you think
it's okay before I commit it.

B

On 8/17/07, bennett kolasinski <bennett.kolasinski at gmail.com> wrote:
>
> Hi David,
>
> I *think* I'm pretty close to being able to remove the old frame
> descriptors pane in annotator to replace it with the new one we've been
> writing, but I wanted to send this as a patch rather than commit to make
> sure I'm doing the right thing.  Please have a look.  Here are my questions
> / comments:
>
>
> - I removed the functions from Annotator that I had moved to
> FrameDescriptorsPane.  For now, I've commented out the methods that I
> removed from Annotator.cxx in Annotator.hxx just to keep track of what I
> removed.  The new pane seems to be functioning fine except when it comes to
> dragging the playhead to a new position- it just doesn't do that.  I'm
> pretty sure that's a signal that I just need to find.  Or... it may have to
> do with the markCurrentSongChanged attribute / signal, which I guess I'd
> have to emit from within FrameDescriptorsPane to get Annotator to update?
>  (see line 168 of FrameDescriptorsPane after applying my patch)
> - I presume the top widget needs to be removed through QtDesigner (or by
> manually editing the .ui XML file)... but I wanted to check with you before
> I went ahead with that.
> - As far as synchronizing zoom, I believe it's as simple as adding another
> signal connection... similar to the one that (AFAI can tell) is in
> vmqt/plot/vmSegmentationPlot.cxx:166.
> - As for live scrolling... I'm still looking for that but any hints are
> appreciated :)
>
>
> onward with the coding...  thanks!
>
> b
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.clam-project.org/pipermail/clam-devel-clam-project.org/attachments/20070817/ec633eaf/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: NewAnnotator.patch
Type: application/octet-stream
Size: 16110 bytes
Desc: not available
URL: <http://lists.clam-project.org/pipermail/clam-devel-clam-project.org/attachments/20070817/ec633eaf/attachment-0004.obj>