[Clam-devel] Re: [PATCH] Re: adding spectrum magnitude to annotator discussion

[David García Garzón]

The problem of being static is on the PFADS::setCurrentTime method. It uses 
the number of bins to jump to the proper frame but it takes such number from 
the binlabels size. You should change it to _nBins.

Change it and if it works, just commit yourself.

Then we should move fast towards display some numerical labels on a widget. (A 
temporary hack on the BarGraph works for me, as it is a proof of concept).


Besides that, getBinLabel implementation generates a very dangerous warning 
message about "returning a reference to a temporary" object. In my opinion, 
this warning should be an compilation error as it is a clear memory leak.

How to solve it? Well the string is constructed so we should return it by copy 
but we are implementing an interface, so the interface itself should be 
modified everywhere we use it. That includes the NetworkEditor :-(


On Wednesday 11 July 2007 05:00:07 bennett kolasinski wrote:
> Hi David,
> I've attached a patch that incorporates your comments (including a rename
> of FirstBinFreq to FirstBinOffset and updated the doxygen comments). 
> Still, though, the BarGraph view of the SpectrumMagnitude data doesn't seem
> to be working-- now it sometimes displays what looks like a fixed array of
> data but doesn't move (at least on my system, which can run Annotator
> excruciatingly slow...).  Any suggestions as to what's going on?
>
> B
>