[Clam-devel] Re: [PATCH] Re: adding spectrum magnitude to annotator discussion

[bennett kolasinski]

Committed revision 10387.

* Add SpectrumMagnitude view to Annotator
* Rename FirstBinFreq -> FirstBinOffset
* Update PoolFloatArrayDataSource::setCurrentTime to use _nBins (animated
SpectrumMagnitude view works!)



Then we should move fast towards display some numerical labels on a widget.
> (A
> temporary hack on the BarGraph works for me, as it is a proof of concept).


OK-- working on that now, will post screenshot / send code when it's
working!


Besides that, getBinLabel implementation generates a very dangerous warning
> message about "returning a reference to a temporary" object. In my
> opinion,
> this warning should be an compilation error as it is a clear memory leak.
>
> How to solve it? Well the string is constructed so we should return it by
> copy
> but we are implementing an interface, so the interface itself should be
> modified everywhere we use it. That includes the NetworkEditor :-(


Hmm... I'll take a look around and will probably bug you on IRC about that
:)

B

On Wednesday 11 July 2007 05:00:07 bennett kolasinski wrote:
> > Hi David,
> > I've attached a patch that incorporates your comments (including a
> rename
> > of FirstBinFreq to FirstBinOffset and updated the doxygen comments).
> > Still, though, the BarGraph view of the SpectrumMagnitude data doesn't
> seem
> > to be working-- now it sometimes displays what looks like a fixed array
> of
> > data but doesn't move (at least on my system, which can run Annotator
> > excruciatingly slow...).  Any suggestions as to what's going on?
> >
> > B
> >
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.clam-project.org/pipermail/clam-devel-clam-project.org/attachments/20070711/69a67ba7/attachment-0004.htm>