[Clam-devel] Re: OSC in CLAM

Pau Arumí parumi at iua.upf.edu
Mon Aug 4 03:02:45 PDT 2008


On dl, 2008-08-04 at 05:39 -0400, Han, Yushen wrote:
> Hi, Pau
> 
> Here is it.

Wrong. This patch creates a new dir plugins/RealtimeSMSSynthesizer
You should be patching the existing ones. I precisely created
"temporal_oboeSynth" so that you move all your code there. Please check
that (old) mail.

Answering previous mail:
> Hi, Pau
> 
> Thanks for your clear instruction.
> 
> I have only one question: is "CLAM/plugins/temporal_oboeSynthesizer" a
> legitimate name
> that has been reserved in CLAM system?

It is a temporal dir to hold changes not merged with Greg's synth. We
can have all the experimental dirs we want in plugins/, no problem :-)

P


> I just made the patch for my working (testbed) dir - it is still
> called "RealtimeSMSSynthesizer".
> But I can rename it and make it again if you want to put it under
> "temporal_oboeSynthesizer".



> Han, Yushen
> 
> On Mon, Aug 4, 2008 at 5:38 AM, Han, Yushen <yushen.han at gmail.com> wrote:
> > Hi, Pau
> >
> > Thanks for your clear instruction.
> >
> > I have only one question: is "CLAM/plugins/temporal_oboeSynthesizer" a
> > legitimate name
> > that has been reserved in CLAM system?
> >
> > I just made the patch for my working (testbed) dir - it is still
> > called "RealtimeSMSSynthesizer".
> > But I can rename it and make it again if you want to put it under
> > "temporal_oboeSynthesizer".
> >
> > Best regards,
> > Han, Yushen
> >
> > On Mon, Aug 4, 2008 at 4:43 AM, Pau Arumí <parumi at iua.upf.edu> wrote:
> >> On dg, 2008-08-03 at 19:58 -0400, Han, Yushen wrote:
> >>> Hi,
> >>>
> >>> Here is the merged plugin - RealtimeSMSSynthesizer
> >>>
> >>> I tried to create a patch by the way described in devel
> >>> "Change dir to the root of your svn tree (the directory containing
> >>> CLAM/ and NetworkEditor/, etc.) and do
> >>> $ svn diff > good-description.patch"
> >>>
> >>> However, it worked only for my modification on CLAM system files but
> >>> not for this new plugin.
> >>> So I send this 960KB patch in a .tar file that contains all the code
> >>> plus test scores (under TestScores).
> >>> Is there a better way to send a patch of a new plugin?
> >>
> >> Yes, sending a .tar with 147(!) files is definitely not the way :-) (see
> >> attached the list of files contained in the .tar file)
> >>
> >> The idea is propose specific (and preferable small) changes to the
> >> repository by means of patches.
> >>
> >> You should be working in either
> >> CLAM/plugins/continuousExcitationSynthesizer
> >> or CLAM/plugins/temporal_oboeSynthesizer
> >> but not a third directory!
> >> The first is the "final" dir and the second is a testbed temporal dir.
> >>
> >> If you want to rename dirs, send proposals to the list.
> >>
> >> About adding new files to a patch:
> >>
> >> 1. do svn add newfile (being in a svn directory)
> >> 2. prepare the patch normally. The new file will be included
> >> 3. some commiter apply the patch
> >> 4. you update the repo: "svn up". BUT BE AWARE of new added files. They
> >> will conflict when doing the svn up. So *before* doing svn up, do "svn
> >> rm newfile".
> >> 5. if 4. fails, apply brute force: move the directory with the new file
> >> (say, temporal_oboeSynthesizer) out of the svn tree. And do svn up.
> >>
> >> So let's try to produce proper patches.
> >> Thanks,
> >>
> >> P
> >>
> >>
> >>
> >>
> >





More information about the clam-devel mailing list