[Clam-devel] Re: [CLAM] multiple ports

[David García Garzón]

On Saturday 16 May 2009 20:48:29 Pau Arumí wrote:
> El ds 16 de 05 de 2009 a les 13:47 +0200, en/na Natanael Olaiz va
>
> escriure:
> > El 05/16/2009 01:32 PM, Pau Arumí escribió:
> > > As Dirk warned, after applying this patch, any old (without applying
> > > the migration script) network will assert/crash NE with this message:
> > >
> > > ##########################################################
> > > ################### ASSERTION FAILED #####################
> > > ##########################################################
> > > At file scons/libs/core/src/OutPortRegistry.cxx line 44
> > > No out port named 'AudioOut'.
> > > Try with: '0
> > >
> > > Given that Sources and Sinks are pervasive in clam networks (and not
> > > all of them are in our svn) I think this is quite risky and I suggest
> > > to take advantage of this change to add some robustness funcionality:
> > >
> > > Instad of asserting when a connection is not correct, the network could
> > > open without that connection and give the user a warning about the
> > > broken connections. This message alone would suffice for making the
> > > user aware about how to fix the network.
> >
> > That would be great!
> >
> > > Additinonally, the message could suggest the user the command to run to
> > > update the new networks - or make it runnable (via a button) in this
> > > message window.
> >
> > To do it safely, that doesn't require a version number on every
> > processing?
>
> Easier: we could store the clam global svn revision number in both the
> clamnetwork xmls and the networks-migration-commands.
> When NE sees an error in the network (such as broken connections) it can
> look both numbers and say "hey, your network is saved with a
> clam-version that needs a migration, let's apply it and open it again"

We are currently storing the clam version in the network file. It is used by 
the clamrefactor script to consider whether it should apply a given rule or 
not. The idea is to apply the upgrade blindlly so it applies just when 
convenient. Not svn version, yet but i wonder how that would help.

David.