[Clam-devel] Copy & Paste processings on canvas patch

[Natanael Olaiz]

El 06/09/2008 10:31 PM, David García Garzón escribió:
> Pau, i just commited the patch previous to the pos and sizes because it 
> modifies the network XML and further changes might be done with care because 
> they might break stored networks. We should be sure that the format is the 
> one to stay for a while.
>
> The point is that the proposed patch stores the position and the size as 
> string:
> boxPos="20,25" boxSize="400,20"
> Is that what we want?
> not x='20' y='25 height='20' widht='400'
> or even position='20,25' size='400,20'?
>   
As you want. Plus, maybe it can be stored in a different path (let's say 
"box") instead "processing".

About the structure, I was thinking about network scalability 
implementation... How to do that? making "super" or "intra" networks? I 
mean, intra:

<network>

    <subnetwork id="subnetwork1">
    .
    .
    </subnetwork>

    <subnetwork id="subnetwork2">
    .
    .
    </subnetwork>

    <subnetwork_connection>
        <port_connection>
        </port_connection>
        <control_connection>
        </control_connection>
    .
    .
    </subnetwork_connection>
</network>

Or super:

<supernetwork>
    <network id="network1">
    </network>
    <network id="network2">
    </network>
    .
    .
</supernetwork>

If I start the implementation on NE maybe the "supernetwork" can be a 
"ClamNetworkCanvas"...

> I also guess that the procAttribMap to store such attributes is a too generic 
> tool that can become subject of abuse if it is in the api. We are expected to 
> have some kind of network configuration/attributes and i don't know if this 
> is missleading when we actually want pos and size. Just a feeling not a 
> conviction. In this part we are more in Pau's zone.
>
> Natanael, you should also review the naming conventions in the new functions: 
> Some local variables starting with upper case and some CripAbrvOnNams. 
> The worst thing on abreviating words is that you never remember which letters 
> you removed. Modern editors have completition. You can also use the context, 
> if the only ones in your context to have positions and sizes are processings  
> you can remove the Proc and call them prositions and sizes.
>   
Yep, I tried to improve that in the new patch.


Regards,
Natanael.

> David.
>
> El Tuesday 10 June 2008 02:24:57 Natanael Olaiz va escriure:
>   
>> El 06/09/2008 03:56 PM, Pau Arumí Albó escribió:
>>     
>>> El dg 08 de 06 de 2008 a les 11:20 +0200, en/na David García Garzón va
>>>
>>> escriure:
>>>       
>>>> I would like to have a commit on the cut&paste patch, to accept this one
>>>> separately. (i want the c&p working :-))) )
>>>>
>>>> Pau, i'll do the commit of the patch before the positions in 30 min if
>>>> you don't do it first.
>>>>         
>>> I like the commited code. And like even more the pace of the
>>> progress :-)
>>>       
>> Thanks :)
>>
>>     
>>> Natanael, are there patches pending for revision?
>>>       
>> Just the store and load of positions and sizes. I attached here an
>> updated version.
>> The major issue that I see with this code is the duplicated code for
>> sizes and positions. In a while I'll send another version which makes
>> all in one step.
>>
>>
>> Regards,
>> Natanael.
>>
>>     
>>> P
>>>
>>>
>>>
>>> _______________________________________________
>>> Clam-devel mailing list
>>> Clam-devel at llistes.projectes.lafarga.org
>>> https://llistes.projectes.lafarga.org/cgi-bin/mailman/listinfo/clam-devel
>>>       
>
>
>
>   

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.clam-project.org/pipermail/clam-devel-clam-project.org/attachments/20080609/0d56a5a2/attachment-0003.htm>